GrantFund events to use BigDecimal for decimal amounts #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeHathaway
reviewed
Aug 9, 2023
src/utils/grants/distribution.ts
Outdated
| @@ -43,6 +43,7 @@ export function loadOrCreateDistributionPeriod(distributionId: Bytes): Distribut | |||
| if (distributionPeriod == null) { | |||
| // create new distributionPeriod if one hasn't already been stored | |||
| distributionPeriod = new DistributionPeriod(distributionId) as DistributionPeriod | |||
| distributionPeriod.distributionId = bytesToBigInt(distributionId) | |||
There was a problem hiding this comment.
We might want to just pass the raw distributionId to this method instead of converting back - wondering how accurate the bytes conversion is
There was a problem hiding this comment.
I thought about that, but there's a local distributionId bytes in all the callers which is used for other purposes. I'll create another local distributionIdRaw on the stack and see how that looks.
There was a problem hiding this comment.
Did this as PR #48.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves consistency with pool events, which use BigDecimals rather than the raw WAD values.
Also added
distributionIdfield toDistributionPeriod, for comparison to onchain values.