Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More GrantFund improvements/fixes #49

Merged
merged 6 commits into from
Aug 11, 2023
Merged

More GrantFund improvements/fixes #49

merged 6 commits into from
Aug 11, 2023

Conversation

EdNoepel
Copy link
Contributor

@EdNoepel EdNoepel commented Aug 10, 2023 •
edited
Loading

  • We already had a mapping of who each voter delegated to, but added array to delegate showing which voters it is delegated from
  • Separate positive and negative votes for proposal
  • Fix bug which was miscounting negative votes as positive votes
  • Fix scale issue with FundingVote.votingPowerUsed

@EdNoepel EdNoepel requested a review from MikeHathaway August 10, 2023 21:22
MikeHathaway
MikeHathaway approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fixes

EdNoepel
EdNoepel commented Aug 10, 2023
View reviewed changes
tests/grant-fund.test.ts
@@ -660,14 +661,14 @@ describe("Grant Fund assertions", () => {
"DistributionPeriodVote",
`${distributionPeriodVoteId.toHexString()}`,
"estimatedInitialFundingStageVotingPowerForCalculatingRewards",
`${expectedVotingPowerUsed}`
'0.000000000000054756'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeHathaway Is there a way to clean up this and line 671? Couldn't figure out how to make the test pass without literals.

@EdNoepel
Copy link
Contributor Author

This is not ready to be merged. There is a bug handling self-delegation. This example query shows an issue when a voter delegates to another and later back to themselves; the delegatedTo does not update properly in that use case.

@EdNoepel
Copy link
Contributor Author

Confirmed resolution of aforementioned issue.

@EdNoepel EdNoepel merged commit 195d65f into develop Aug 11, 2023
@EdNoepel EdNoepel deleted the delegated-from branch August 11, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeHathaway MikeHathaway MikeHathaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdNoepel @MikeHathaway