rc3 stuff missed from last PR #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yesterday I found two more missed events. Today I found four more, which actually require some schema work. |
|
Deployment now works. I still need to finish implementing handlers for LPTransferors and LPAllowances. |
|
@MikeHathaway Ready for re-review. Unit tests need some work. Let's meet up later today or tomorrow to discuss prioritization of that and other subgraph tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixed some things missed in my last PR:
PositionManagerandRewardsManagerchangesRAYs withWADs.Out of scope
Unfortunately, this does not fix the error I was having, but instead moves it to a different line: