Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GrantFund Updates and Bug Fixes #53

Merged
merged 7 commits into from
Aug 15, 2023
Merged

GrantFund Updates and Bug Fixes #53

merged 7 commits into from
Aug 15, 2023

Conversation

MikeHathaway
Copy link
Contributor

@MikeHathaway MikeHathaway commented Aug 15, 2023 •
edited
Loading

  • Create a 1-1 relationship between Proposal and FundingVote and ScreeningVote entities
  • Fix fundingStage vote tracking and votingPower tracking
  • Associate VoteCast event entities with their respective FundingVote and ScreeningVote entities

@MikeHathaway MikeHathaway requested a review from EdNoepel August 15, 2023 20:35
@MikeHathaway MikeHathaway marked this pull request as draft August 15, 2023 21:14
@MikeHathaway MikeHathaway marked this pull request as ready for review August 15, 2023 21:38
@MikeHathaway MikeHathaway changed the title fix getFundingVotingPowerUsed GrantFund Updates and Bug Fixes Aug 15, 2023
EdNoepel
EdNoepel approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/utils/grants/voter.ts Outdated Show resolved Hide resolved
@MikeHathaway MikeHathaway merged commit 80a35e5 into develop Aug 15, 2023
@MikeHathaway MikeHathaway deleted the votingPower-fix branch August 15, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdNoepel EdNoepel EdNoepel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeHathaway @EdNoepel