-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct issues handling interest rate update events #57
Conversation
Not convinced this is right yet. Experimentally, most of the fee rates have the same value for old and new. Investigating. |
Seems the problem is that the |
…iably provide them
Solution was to remove old fee rates from the event, as providing them would introduce more complexity than they were worth. Note that we can still provide the old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 thank you
Moved logic for updating
depositFeeRate
intoupdatePool
, eliminating the need for redundantgetRateInfo
calls. Centralized logic for handling rate resets and updates to a single method inbase-pool.ts
. Removed old fee rates from schema, since we cannot reliably provide them.