Fix bug awarding LP to wrong actor handling bucketTake #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A typo caused both the kicker and taker to get the LP which should be awarded to taker in a
bucketTake. Updated both pools to award kicker LP to kicker. Integration tested onparvati.Added a
bucketIndexfield toLend, allowing lends to be filtered by bucket index. GraphQL has limitation that consumer cannot filter on subproperties (bucket.bucketIndex).Attempted to consolidate
handleBucketTakelogic intobase-pool.ts, but the logic was too different between pool types.