update Position schema; add PositionLend entity #62
Conversation
src/mappings/position-manager.ts
Outdated
| } | ||
| const positionLend = loadOrCreatePositionLend(redeem.tokenId, bucketId, index) | ||
| positionLend.lpb = ZERO_BD | ||
| positionLend.lpbValueInQuote = ZERO_BD |
There was a problem hiding this comment.
Seems unnecessary to mutate anything besides lpb, because the entity will be removed from the store.
src/mappings/base/base-pool.ts
Outdated
| for (let i = 0; i < bucket.positionLends.length; i++) { | ||
| const positionLendId = bucket.positionLends[i] | ||
| const positionLend = PositionLend.load(positionLendId)! | ||
| positionLend.depositTime = bucketBankruptcy.blockTimestamp.plus(ONE_BI) |
There was a problem hiding this comment.
Curious why we would update anything aside from positionLend.lpb here. By setting lpb to 0, saveOrRemovePositionLend should always call store.remove, so these mutations would never be persisted. Regardless, advancing depositTime doesn't seem appropriate.
There was a problem hiding this comment.
I will remove those updates. The depositTime advancing matches the contract logic
src/mappings/position-manager.ts
Outdated
| // remove position from old account | ||
| const oldOwnerAccount = loadOrCreateAccount(transfer.from) | ||
| const index = oldOwnerAccount.positions.indexOf(bigIntToBytes(transfer.tokenId)) | ||
| if (index != -1) oldOwnerAccount.positions.splice(index, 1) |
There was a problem hiding this comment.
That's not going to work. When we call entity.collection, it returns a copy of the collection. Mutations on this collection will not persist when save is called on line 296.
There was a problem hiding this comment.
Updated, and also updated in handleBurn.
src/utils/position.ts
Outdated
| const bucket = Bucket.load(positionLend.bucket)! | ||
| const existingBucketIndex = bucket.positionLends.indexOf(positionLend.id) | ||
| if (existingBucketIndex != -1) { | ||
| bucket.positionLends.splice(existingBucketIndex, 1) |
There was a problem hiding this comment.
This and line 104 mutate a copy of the collection, and will not effect the entity, even when the caller calls .save.
There was a problem hiding this comment.
Updated accordingly
PositionLendentity and associate withPositionandBucketin many-to-one relationship.PositionandAccountentitiestokenURIattribute toPositionentitylpbandlpbValueInQuotefor eachPositionLendassociated with aPositionby callinggetPositionInfoMoveLiquidityand removeLendupdate logic as this is already handled in the associatedMoveQuoteTokeneventMoveLiquiditytest