Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPB event updates and remove RewardsManager #67

Merged
merged 5 commits into from
Sep 12, 2023
Merged

LPB event updates and remove RewardsManager #67

merged 5 commits into from
Sep 12, 2023

Conversation

MikeHathaway
Copy link
Contributor

@MikeHathaway MikeHathaway commented Sep 12, 2023 •
edited
Loading

@MikeHathaway MikeHathaway marked this pull request as ready for review September 12, 2023 19:24
EdNoepel
EdNoepel approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but what about ClaimRewards and UpdateExchangeRates? Should those entities be renamed in another PR?

@MikeHathaway
Copy link
Contributor Author

MikeHathaway commented Sep 12, 2023 •
edited
Loading

Looks good, but what about ClaimRewards and UpdateExchangeRates? Should those entities be renamed in another PR?

We can probably just remove all the RewardsManager logic entirely, as it will never be used. I can add that to this PR.

@EdNoepel
Copy link
Contributor

EdNoepel commented Sep 12, 2023 •
edited
Loading

We can probably just remove all the RewardsManager logic entirely, as it will never be used.

Agree; would rather not need to maintain/test that functionality.

@MikeHathaway MikeHathaway changed the title LPB Event Updates LPB event updates and remove RewardsManager Sep 12, 2023
EdNoepel
EdNoepel approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeHathaway MikeHathaway merged commit 615d00b into develop Sep 12, 2023
@MikeHathaway MikeHathaway deleted the lpb-management branch September 12, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdNoepel EdNoepel EdNoepel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeHathaway @EdNoepel