Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue maintaining auction price #68

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

EdNoepel
Copy link
Contributor

If auction was settled in the same TX as it was taken, auction price will be recorded as 0 after the take, because the liquidation will have been removed. Instead of querying auction price from the auction status, calculate it based upon quote token paid and collateral received.

@EdNoepel EdNoepel marked this pull request as ready for review September 14, 2023 20:33
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdNoepel EdNoepel merged commit 35c5de0 into develop Sep 18, 2023
@EdNoepel EdNoepel deleted the 0-price-after-settle branch September 18, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants