Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC8 Updates #75

Merged
merged 11 commits into from
Oct 30, 2023
Merged

RC8 Updates #75

merged 11 commits into from
Oct 30, 2023

Conversation

MikeHathaway
Copy link
Contributor

@MikeHathaway MikeHathaway commented Oct 18, 2023

@MikeHathaway MikeHathaway changed the title remove momp from pool; add referencePrice to liquidationAuction; remo… RC8 Updates Oct 18, 2023
@MikeHathaway MikeHathaway requested a review from EdNoepel October 18, 2023 15:56
Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good. I confirmed neutralPrice is already updated through updateLiquidation, since that now changes upon take and bucketTake.

networks.json needs to be updated for goerli and ganache. You could update line 5 of local/docker-compose to rc8b to test the local indexer setup.

I assume it makes sense to put PoolInfoUtilsMulticall into a separate PR so we can get this out the door more quickly.

@MikeHathaway
Copy link
Contributor Author

So far so good. I confirmed neutralPrice is already updated through updateLiquidation, since that now changes upon take and bucketTake.

networks.json needs to be updated for goerli and ganache. You could update line 5 of local/docker-compose to rc8b to test the local indexer setup.

I assume it makes sense to put PoolInfoUtilsMulticall into a separate PR so we can get this out the door more quickly.

Updated ABIs and networks.json unsure of the start block for georli.

Was planning on adding the multicall support as a separate PR.

@MikeHathaway MikeHathaway requested a review from EdNoepel October 18, 2023 19:32
Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated addresses. Looks good. Will need to coordinate deployment.

networks.json Outdated Show resolved Hide resolved
@EdNoepel
Copy link
Contributor

I tested deployment on ushas, but due to lack of activity, it was not really exercised.

@EdNoepel EdNoepel merged commit d73b0ec into develop Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants