Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc fixes #8

Merged
merged 2 commits into from
Apr 7, 2023
Merged

misc fixes #8

merged 2 commits into from
Apr 7, 2023

Conversation

EdNoepel
Copy link
Contributor

@EdNoepel EdNoepel commented Apr 6, 2023 •
edited
Loading

Haven't worked out all the issues yet, but wanted to get these fixes in:

  • Replace event.transaction.to! with event.address to handle calls from proxy contracts.
  • Add missing ABIs to PositionManager manifest.
  • Populate non-nullable tokenId when in handleMoveStakedLiquidity.

@EdNoepel EdNoepel marked this pull request as ready for review April 6, 2023 04:51
@EdNoepel EdNoepel requested a review from MikeHathaway April 6, 2023 04:51
MikeHathaway
MikeHathaway approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one question about abi duplication in subgraph.yaml

subgraph.yaml
@@ -25,6 +25,10 @@ dataSources:
abis:
- name: PositionManager
file: ./abis/PositionManager.json
- name: ERC20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just access those ABIs via the factory instead of duplicating here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added them to the manifest to resolve an indexing error where it reported a missing ABI. IIRC, it was erroring out upon mint. Seemed like it didn't involve the AssemblyScript at all. Happy to try another approach if you have a suggestion.

@EdNoepel EdNoepel merged commit 927e566 into develop Apr 7, 2023
@EdNoepel EdNoepel deleted the 0523 branch April 7, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeHathaway MikeHathaway MikeHathaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdNoepel @MikeHathaway