fix: correct logic for updatePositionLends helper #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbaniac
force-pushed
the
lend-position-fix
branch
from
24c9caf to
a38b75d
Compare
imbaniac
force-pushed
the
lend-position-fix
branch
from
a38b75d to
35c0fe7
Compare
EdNoepel
approved these changes
Nov 9, 2023
| @@ -100,9 +97,6 @@ export function handleMemorializePosition( | |||
| memorialize.blockTimestamp = event.block.timestamp | |||
| memorialize.transactionHash = event.transaction.hash | |||
|
|
|||
| // update entities | |||
| const position = loadOrCreatePosition(memorialize.tokenId) | |||
|
|
|||
There was a problem hiding this comment.
Indeed; this is created upon mint, and gets mutated by updatePositionLends on line 121.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updatePositionLendshad incorrect conditions for adding lendPosition toBucketandPositionentities. Also it didn't save properly.