Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ldap search scope #1948

Merged
merged 1 commit into from
Mar 9, 2024
Merged

feat: add ldap search scope #1948

merged 1 commit into from
Mar 9, 2024

Conversation

Meierschlumpf
Copy link
Collaborator

Category

Bugfix / Feature

Overview

I've added a new environment variable to define the search scope for ldap

Issue Number

Closes #1925

New Vars

AUTH_LDAP_SEARCH_SCOPE with the options base, one and sub

@Meierschlumpf Meierschlumpf added 🐛 Bug Something isn't working ✨ Feature A feature you'd like to be added labels Mar 9, 2024
@Meierschlumpf Meierschlumpf self-assigned this Mar 9, 2024
Copy link

github-actions bot commented Mar 9, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 16.85% 5043 / 29913
🔵 Statements 16.85% 5043 / 29913
🔵 Functions 6.69% 32 / 478
🔵 Branches 37.79% 130 / 344
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/env.js 82.63% 0% 0% 82.63% 10-12, 53-64, 69-78
src/utils/auth/ldap.ts 0% 0% 0% 0% 1-165
Generated in workflow #6432

@manuel-rw manuel-rw merged commit 9c81d34 into dev Mar 9, 2024
4 checks passed
@Meierschlumpf Meierschlumpf deleted the ldap-add-search-scope branch March 9, 2024 15:43
truecharts-admin added a commit to truecharts/charts that referenced this pull request Mar 16, 2024
…caf77d7 by renovate (#19304)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/ajnart/homarr](https://github.com/ajnart/homarr) | patch |
`0.15.0` -> `0.15.2` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ajnart/homarr (ghcr.io/ajnart/homarr)</summary>

### [`v0.15.2`](https://github.com/ajnart/homarr/releases/tag/v0.15.2)

[Compare
Source](https://github.com/ajnart/homarr/compare/v0.15.1...v0.15.2)

> \[!NOTE]\
> We've been working actively on working torwards version 1.0 which will
include many improvements to performance, security and the overall look
& feel of Homarr. It will greatly overhaul the technical architecture of
Homarr. This work is done by volunteers. Please consider supporting our
work via donations at https://opencollective.com/homarr

#### v0.15.2: Hotfix, OMV 7 support

- Fixed an issue with the image where it would notify you to upgrade to
`0.15.1`, even though you were running `0.15.1`
-   Added support for OMV 7
-   Updated Crowdin translations

#### What's Changed

- chore: increase version by
[@&#8203;manuel-rw](https://github.com/manuel-rw) in
[ajnart/homarr#1960
- feat: OMV 7 support by
[@&#8203;hillaliy](https://github.com/hillaliy) in
[ajnart/homarr#1959
- feat: Apply translation automation from select option to multi-select…
by [@&#8203;Tagaishi](https://github.com/Tagaishi) in
[ajnart/homarr#1963
- chore: new Crowdin updates by
[@&#8203;ajnart](https://github.com/ajnart) in
[ajnart/homarr#1949
- core: increase version to 0.15.2 by
[@&#8203;manuel-rw](https://github.com/manuel-rw) in
[ajnart/homarr#1967

**Full Changelog**:
ajnart/homarr@v0.15.1...v0.15.2

### [`v0.15.1`](https://github.com/ajnart/homarr/releases/tag/v0.15.1)

[Compare
Source](https://github.com/ajnart/homarr/compare/v0.15.0...v0.15.1)

> \[!NOTE]\
> We've been working actively on working torwards version 1.0 which will
include many improvements to performance, security and the overall look
& feel of Homarr. It will greatly overhaul the technical architecture of
Homarr. This work is done by volunteers. Please consider supporting our
work via donations at https://opencollective.com/homarr

#### Version 0.15.1: Fixes wih SSO, OMV integration and weekly weather
forecast

##### SSO fixes & improvements

- Added environment variable `AUTH_OIDC_SCOPE_OVERWRITE` to override the
OIDC scopes
-   Fixed redirection for OIDC logins
- Added the environment variable `AUTH_LDAP_SEARCH_SCOPE` to modify the
LDAP search scope between `base`, `one` or `sub`.
- Added debug information on the login page when authentication
providers are set incorrectly:

![310673082-a376bd01-e6bf-449b-93e8-f050da3fdef8](https://github.com/ajnart/homarr/assets/30572287/41c844b0-ce8b-43e4-80f8-526b20f2684b)

##### OMV widget

[@&#8203;hillaliy](https://github.com/hillaliy) has contributed a new
system health widget that integrates with
https://www.openmediavault.org/

![image](https://github.com/ajnart/homarr/assets/30572287/13ea31ef-85f3-401c-a2e6-ca89783cf3ce)

##### Weekly forecast

The weather widget can now display a weekly forecast:

![image](https://github.com/ajnart/homarr/assets/30572287/14fab53a-2caa-49be-8591-6f8b7afb9fb7)

##### Lithuanian and Estonian languange support

We have added Lithuanian and Estonian to Homarr. As always, our
community can translate Homarr into these languages:
https://crowdin.com/project/homarr

##### Improved torrent tile performance & ordering

Thanks to our contributors, the torrent widget now uses virtualization
to lower the required work on the client when rendering the list of
torrents. This results in more fluid scrolling and resizing of the
widget:

https://github.com/ajnart/homarr/assets/162878798/8a21eec2-2f6e-4b0b-8653-7cd730d7d697

Ordering columns is also now possible:

![](https://github.com/ajnart/homarr/assets/26098587/78e9636e-9ac5-44fe-aafc-d4df341ecf9b)

#### What's Changed

- feat: add environment variable to overwrite oidc scopes by
[@&#8203;Meierschlumpf](https://github.com/Meierschlumpf) in
[ajnart/homarr#1913
- fix: redirect OIDC by
[@&#8203;Meierschlumpf](https://github.com/Meierschlumpf) in
[ajnart/homarr#1911
- fix: set maximum size for indexer manager to 12 by
[@&#8203;Tagaishi](https://github.com/Tagaishi) in
[ajnart/homarr#1912
- feat: add OMV integration / widget by
[@&#8203;hillaliy](https://github.com/hillaliy) in
[ajnart/homarr#1879
- feat: add ldap search scope by
[@&#8203;Meierschlumpf](https://github.com/Meierschlumpf) in
[ajnart/homarr#1948
- feat: AUTH_PROVIDER log when incorrect and show error in login page by
[@&#8203;Tagaishi](https://github.com/Tagaishi) in
[ajnart/homarr#1943
- feat: add Lithuanian support by
[@&#8203;ajnart](https://github.com/ajnart) in
[ajnart/homarr#1935
- feat: Mention Emby on Jellyfin integration by
[@&#8203;Tagaishi](https://github.com/Tagaishi) in
[ajnart/homarr#1917
- feat: add weekly forecast to weather widget by
[@&#8203;hillaliy](https://github.com/hillaliy) in
[ajnart/homarr#1932
- feat: add Estonian language by
[@&#8203;ajnart](https://github.com/ajnart) in
[ajnart/homarr#1931
- chore: new Crowdin updates by
[@&#8203;ajnart](https://github.com/ajnart) in
[ajnart/homarr#1890
- fix: death links in readme by
[@&#8203;Meierschlumpf](https://github.com/Meierschlumpf) in
[ajnart/homarr#1953
- feat: Improve TorrentTile rendering performance by
[@&#8203;diederbert](https://github.com/diederbert) in
[ajnart/homarr#1951
- fix: death app links by
[@&#8203;Meierschlumpf](https://github.com/Meierschlumpf) in
[ajnart/homarr#1955
- feat: add column ordering in torrent widget by
[@&#8203;hillaliy](https://github.com/hillaliy) in
[ajnart/homarr#1952

#### New Contributors

- [@&#8203;diederbert](https://github.com/diederbert) made their first
contribution in
[ajnart/homarr#1951

**Full Changelog**:
ajnart/homarr@v0.15.0...v0.15.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDkuMyIsInVwZGF0ZWRJblZlciI6IjM3LjI0OS4zIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working ✨ Feature A feature you'd like to be added
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

LDAP: Cannot read properties of undefined (reading 'dn')
2 participants