Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add dns disable timer #2029

Merged
merged 9 commits into from
May 23, 2024
Merged

Conversation

hillaliy
Copy link
Contributor

@hillaliy hillaliy commented Apr 26, 2024

Category

Feature

Overview

Add timer to disable dns

Issue Number

Related issue: #2026

Screenshot

Screenshot 2024-04-26 at 19 16 49

@dslatt
Copy link
Contributor

dslatt commented Apr 27, 2024

looks good.

2 things I noticed.

1 - translation isn't working
Screenshot from 2024-04-27 07-36-15

2 - trying to disable an individual integration from widget seems to disable both.

@hillaliy
Copy link
Contributor Author

hillaliy commented Apr 27, 2024

I'll check it.

@hillaliy
Copy link
Contributor Author

Screenshot 2024-04-28 at 17 39 14

@hillaliy
Copy link
Contributor Author

I install PiHole on my test server. Everything work as expected.

@dslatt
Copy link
Contributor

dslatt commented Apr 28, 2024

everything works for me too

@manuel-rw
Copy link
Collaborator

wrong field, sorry :)

@hillaliy
Copy link
Contributor Author

hillaliy commented Apr 30, 2024

New design with @tag inspiration 😀

Screenshot 2024-04-30 at 20 19 11 Screenshot 2024-04-30 at 20 19 29

@dslatt
Copy link
Contributor

dslatt commented Apr 30, 2024

Looks great 😃 with the changes

src/widgets/dnshole/DnsHoleControls.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@SeDemal SeDemal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for some, up to you on others.
Looks really great already though, timer definitely was missing, it's a great addition.

src/widgets/dnshole/DnsHoleControls.tsx Outdated Show resolved Hide resolved
src/widgets/dnshole/DnsHoleControls.tsx Show resolved Hide resolved
src/widgets/dnshole/DnsHoleControls.tsx Show resolved Hide resolved
src/widgets/dnshole/DnsHoleControls.tsx Outdated Show resolved Hide resolved
src/widgets/dnshole/DnsHoleControls.tsx Show resolved Hide resolved
src/widgets/dnshole/TimerModal.tsx Outdated Show resolved Hide resolved
src/widgets/dnshole/TimerModal.tsx Outdated Show resolved Hide resolved
@manuel-rw manuel-rw merged commit afdca50 into ajnart:dev May 23, 2024
2 checks passed
@hillaliy hillaliy deleted the dns-controls-timer branch May 23, 2024 16:22
truecharts-admin added a commit to truecharts/charts that referenced this pull request Sep 2, 2024
…c13f04c by renovate (#25798)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/ajnart/homarr](https://github.com/ajnart/homarr) |
patch | `0.15.3` -> `0.15.4` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ajnart/homarr (ghcr.io/ajnart/homarr)</summary>

###
[`v0.15.4`](https://github.com/ajnart/homarr/releases/tag/v0.15.4)

[Compare
Source](https://github.com/ajnart/homarr/compare/v0.15.3...v0.15.4)

> \[!NOTE]\
> We've been working actively on working torwards version 1.0 which will
include many improvements to performance, security and the overall look
& feel of Homarr. It will greatly overhaul the technical architecture of
Homarr. This work is done by volunteers. Please consider supporting our
work via donations at https://opencollective.com/homarr

> \[!CAUTION]\
> We are **dropping support for armv7**. Old Raspberry Pi and arm
devices are no longer supported by some of our upstream dependencies.
> Our building framework for 1.0 also doesn't support armv7. This change
will only affect a very small amount of devices.
> We **recommend you to upgrade to a newer architecture** if you are
affected by this change. Cheap SBC's can be bought for very cheap that
support arm64.

#### Disable PiHole & AdGuard Home temporarily

Instead of permanently disabling them, Homarr can now disable them for a
certain time period: <img width="334"
alt="326053459-ca5d39cf-d53c-4597-b5e6-40288e51f66d"
src="https://github.com/user-attachments/assets/82c8a053-b8b9-4e9f-91bc-6e51b326ea25">

#### Proxmox uptime

The health monitoring widget can now display the uptime of your Proxmox
system:

![351717193-215cb6e2-5d9f-4884-9e44-2b1fd91e71cf](https://github.com/user-attachments/assets/a5c12fe3-7979-44a6-980d-84ad867af66b)

#### What's Changed

- Add `key` for custom favicon by
[@&#8203;ajnart](https://github.com/ajnart) in
[ajnart/homarr#2052
- Add New Language Arabic by
[@&#8203;bo3bdo](https://github.com/bo3bdo) in
[ajnart/homarr#2051
- Feature: Add dns disable timer by
[@&#8203;hillaliy](https://github.com/hillaliy) in
[ajnart/homarr#2029
- New Crowdin updates by
[@&#8203;ajnart](https://github.com/ajnart) in
[ajnart/homarr#2038
- feat: add indexers site hyperlink by
[@&#8203;hillaliy](https://github.com/hillaliy) in
[ajnart/homarr#2061
- feat: add Proxmox Uptime View by
[@&#8203;JasonLeeB06](https://github.com/JasonLeeB06) in
[ajnart/homarr#2092
- fix:
[#&#8203;2086](https://github.com/ajnart/homarr/issues/2086)
enforce password requirements for admin user by
[@&#8203;manuel-rw](https://github.com/manuel-rw) in
[ajnart/homarr#2098
- fix:
[#&#8203;1707](https://github.com/ajnart/homarr/issues/1707)
refech interval app pings by
[@&#8203;manuel-rw](https://github.com/manuel-rw) in
[ajnart/homarr#2097

#### New Contributors

- [@&#8203;bo3bdo](https://github.com/bo3bdo) made their first
contribution in
[ajnart/homarr#2051
- [@&#8203;JasonLeeB06](https://github.com/JasonLeeB06) made
their first contribution in
[ajnart/homarr#2092

**Full Changelog**:
ajnart/homarr@v0.15.3...v0.15.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants