Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add key for custom favicon #2052

Merged
merged 3 commits into from
May 16, 2024
Merged

Add key for custom favicon #2052

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
051f439
Add `key` for custom favicon
ajnart May 15, 2024
5043b9c
Refactor favicon links in Meta components
ajnart May 15, 2024
84f57bb
chore: add test:docker script for local development
ajnart May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/layout/Meta/BoardHeadOverride.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import Head from 'next/head';
import React from 'react';
import { useConfigContext } from '~/config/provider';
import { firstUpperCase } from '~/tools/shared/strings';

Expand All @@ -15,7 +14,7 @@ export const BoardHeadOverride = () => {
return (
<Head>
<title>{title}</title>
<meta name="apple-mobile-web-app-title" content={title} />
<meta key="favicon" name="apple-mobile-web-app-title" content={title} />

{faviconUrl && faviconUrl.length > 0 && (
<>
Expand Down
2 changes: 1 addition & 1 deletion src/components/layout/Meta/CommonHead.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const CommonHead = () => {
return (
<Head>
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1" />
<link rel="shortcut icon" href="/imgs/favicon/favicon.svg" />
<link key="favicon" rel="shortcut icon" href="/imgs/favicon/favicon.svg" />

<link crossOrigin="use-credentials" rel="manifest" href="/site.webmanifest" />

Expand Down
Loading