Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notebook widget overflow on mobile #2112

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

joser93
Copy link
Contributor

@joser93 joser93 commented Aug 24, 2024

Greetings

Category

Bugfix

Overview

Testing and handling a board with mobile size with 1 column, found that by default the notebook widget requires 2 width columns, causing an overflow on the view and might not be ideal. I get why was implemented in the first place and make sure that as soon that the widget has the appropiate size as soon is created, but maybe is required a better implementation that allow min width columns per screen device? but that's a challenge. For the moment, this will fix the overflow.

Screenshot

Before:
image

After:
image

I hope you find it useful.

@joser93 joser93 changed the title [Bugfix] Change min width to 1, Issue overflow on mobile size with 1 column [Bugfix] Notebook widget: Change min width to 1, Issue overflow on mobile size with 1 column Aug 24, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋. Thank you for making your first contribution to Homarr. Please ensure that you've completed all the points in the TODO checklist. We'll review your changes shortly.

@manuel-rw manuel-rw changed the title [Bugfix] Notebook widget: Change min width to 1, Issue overflow on mobile size with 1 column fix: notebook widget overflow on mobile Aug 30, 2024
@manuel-rw manuel-rw merged commit eba3010 into ajnart:dev Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants