Adding org.ajoberstar.grgit Gradle plugin #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is being migrated from gradle-git. Differences from 1.7.x gradle-git: - Allow applying to projects besides the rootProject - Warn if project was applied to root project and a subproject - Add a close task that finalizes all other tasks This resolves #178.
Just basic testing that the Git repo is found or not.
Using a task, requires finalizing all other tasks, which has the potential to cause a cycle if there is some other plugin/logic trying to do the same thing. A build listener meets the need by just delaying until all tasks have executed.
Given that it doesn't replace the Closure syntax, without breaking existing usage, this doesn't add much and just introduces more to support and document.
ajoberstar
commented
Jul 30, 2017
| } | ||
| prj.ext.grgit = grgit | ||
| } | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being migrated from gradle-git. Differences from 1.7.x
gradle-git:
This resolves #178.