Register tasks earlier #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jnehlmeier noticed that it can be difficult to create other settings plugins that build off the tag/push tasks that reckon registers due to them being registered after projectLoaded. Since these are only added to the root project, its a trivial tweak to just register directly on rootProject and avoid the extra ordering confusion for downstream authors. Fixes #200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jnehlmeier noticed that it can be difficult to create other settings plugins that build off the tag/push tasks that reckon registers due to them being registered after projectLoaded.
Since these are only added to the root project, its a trivial tweak to just register directly on rootProject and avoid the extra ordering
confusion for downstream authors.
Fixes #200