feat: improve performance of Table node #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor ItemCollection to ensure headers and rows fallback to empty arrays - Include useMemo and useReactTable hooks for optimizing re-renders - Integrate virtualization with useVirtualizer for large data sets
- Extracted TableHandleComponent for better code modularity - Created LoadingComponent to improve readability when data fetch is pending - Cleaned up redundant code and improved logic for rendering table & cells
- Added unique id and custom cell rendering logic to table headers - Adjusted virtualizer estimateSize and container height for consistency - Simplified cell rendering and upgraded header z-index for visibility
- Adjust TRUNCATE_CELL_LENGTH for cell content truncation length - Implement defaultColumn sizing for consistent column behavior
- Increased TRUNCATE_CELL_LENGTH constant from 15 to 50 characters - Removed width full restriction to improve component flexibility - Cleaned up flex and grid usage for better performance
- Set default viewport size in Cypress configuration - Refactor TableNodeComponent tests for readability and maintenance
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ajthinking
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the table receives over 10K items, try scrolling through the table to see the performance.
10000-scroll.mp4