Improve JSONSchemaType errors #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript seems to report errors with the last member of a valid union first, so this rearranges the type so the simple union types come first, and the type that represents the meaty types comes last. This should help make errors like the one in ajv-validator#1521 more clear.
|
Thank you! what happened with the build I wonder... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
#1521 highlighted that the new additions for union types made errors less clear.
What changes did you make?
Rearranged the largest union in the type to put the non union types last. Typescript seems to default to the last element when reporting errors. I think it will report all if you turn on verbose reporting, but most people probably aren't.
Is there anything that requires more attention while reviewing?
It's just a simple reordering. Not sure if git's diff picks up on that, but it should be pretty trivial.