Use root schemaEnv when resolving references in oneOf #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! |
|
@epoberezkin I know you are probably very busy, but is it possible to cut a 8.10.1 release so that this fix is available via npm? |
|
@epoberezkin I am waiting for the next release too, do you have any prediction about that? |
|
right, sorry - it was nagging me that I didn't do it - thanks for the pings - will do today/tomorrow! |
|
It’s released now |
This was referenced May 22, 2024
This was referenced Jun 25, 2024
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
Fixes #1899
What changes did you make?
Use root schemaEnv when resolving references in oneOf
Is there anything that requires more attention while reviewing?
No this should be a simple fix