fix: #2482 Infinity and NaN serialise to null #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
reviewed
Aug 18, 2024
epoberezkin
reviewed
Aug 18, 2024
lib/compile/jtd/serialize.ts
Outdated
Comment on lines
232
to
241
| const condition = _`${data} === Infinity || ${data} === -Infinity || Number.isNaN(${data})` | ||
| const addNumber = (): CodeGen => gen.add(N.json, _`"" + ${data}`) | ||
|
|
||
| if (self.opts.specialNumbers === "null") { | ||
| gen.if(condition, () => gen.add(N.json, _`null`), addNumber) | ||
| } else if (self.opts.specialNumbers === "string") { | ||
| gen.if(condition, () => gen.add(N.json, str`"${data}"`), addNumber) | ||
| } else { | ||
| addNumber() | ||
| } |
There was a problem hiding this comment.
x !== x avoids function call overhead, the only advantage of Number.isNaN is clarity, but we're optimizing for performance here.
epoberezkin
reviewed
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
#2482
What changes did you make?
Added an option to support serializing the special case numbers
Infinity,-InfinityandNaN. See added docs for expected behavior but basically these options help to avoid invalid JSON when dealing with these values.Is there anything that requires more attention while reviewing?
The tests and the new docs explain it all.