expose the last_forwarded_ip/2 function for usage outside of Plug #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some circumstances, it is possible to get a subset of headers without the full conn. An example of this is in Phoenix sockets, where only x_headers can be fetched. https://hexdocs.pm/phoenix/Phoenix.Endpoint.html#socket/3-shared-configuration In this case, currently using RemoteIP involves doing something like this as conn is not available: ```elixir def connect({connect_info: %{x_headers: headers}}) do RemoteIp.call(%Plug.Conn{req_headers: headers}, RemoteIp.init()).remote_ip end ``` With this PR, someone using this library with Phoenix sockets could do: ```elixir RemoteIp.last_forwarded_ip(headers) ```
|
Sorry for the delayed response. It's a great idea, and I appreciate the PR. I'll probably want to massage around the actual implementation, both to appease my delicate sensibilities (I get weird about things 😅) and in light of possibly-changing APIs from #8. I'll try to get to this soon. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some circumstances, it is possible to get a subset of headers without the
full conn. An example of this is in Phoenix sockets, where only x_headers can be
fetched.
https://hexdocs.pm/phoenix/Phoenix.Endpoint.html#socket/3-shared-configuration
In this case, currently using RemoteIP involves doing something like this as
conn is not available:
With this PR, someone using this library with Phoenix sockets could do: