-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make main tiles configurable via metadata #98
Comments
I can try to take this on! |
oh, that would be excellent @mspilimbergo ! - this would be a precursor to akash-network/console#100 (which is obviously very exciting) so you can take that next, if you figure this out. Meanwhile we're working on designs for #100 . I'll create the deploy-templates for this issue (under https://github.com/akash-network/deploy-templates) and tag you on that. |
Sounds good!! Yeah, would happy to take on #100 if all goes well here. Btw, I don't see any changes to the deploy-templates. Do you want me to create the nodes-master folder and PR it into https://github.com/akash-network/deploy-templates ? Thanks! |
Was just working on it :) -- akash-network/deploy-templates#3 |
I see - great! |
merged now - feel free to suggest any changes to the metadata file as you code up the logic. And note that a few icons referenced from the file are missing under https://github.com/akash-network/deploy-templates/tree/main/template-icons/nodes/80by80 -- I'll get these from our designer tomorrow (he's asleep now) and update github but I wanted to get you something to unblock you first |
hey @mspilimbergo - couple updates/ follow ups:
|
hey @mspilimbergo - just checking in. Any updates? Would like to get this in soon. |
Hi @anilmurty. I'm looking forward to pick this issue up. Got a good understanding of the code and requirements. |
Made a PR to correct the JSON syntax in the |
Thanks @kaushik-rishi - go for it! |
Quick Question, are we planning to remove all of the icons from https://github.com/akash-network/console/tree/main/web/src/assets/images and reference them from the |
I'd prefer to keep them where the deploy templates are but if it is too much work we can leave them where they are and update the JSON templates to reference the location rather than hard coding it. |
We can do it either ways, i've updated the Way - 1 (if we want to use the deployment templates) Way - 2 (if we want to use the static assets) Which one should i go forward with ? PR #110 |
Great progress @kaushik-rishi @jtary - what's your preference here? I lean towards having all assets and metadata for the tiles in one place so it is easy to modify/ reference but don't want to introduce unnecessary complexity in the code. |
Hey @anilmurty - so sorry about the late update. I had a family emergency and was forced to travel outside the country. Good to know that @kaushik-rishi was able to take care of it, looked at his PRs, and they look great. Hope to be able to keep contributing! |
Thanks @mspilimbergo - hope all's well. Looking forward to your contributions- please feel free to comment on other issues that interest you. |
I'm closing this now as it is implemented and deployed to production |
Background:
Console today has a bunch of top level tiles and then sub-tiles under each top-level tile.
Top level tiles
Sub-tiles under a top level tile:
The contents of the sub-level tiles are configurable via metadata files located in https://github.com/akash-network/deploy-templates (one per template). For example, here is the metadata file that controls the colors, logo, number of tiles, copy (text) etc for the "Akash" screenshot shown above: https://github.com/akash-network/deploy-templates/blob/main/akash/metadata.json
There is no such configurability for the tiles on the main page. We would like to add this, so that we can easily add or remove top level tiles from the UI.
Requirements:
- Tiles should be displayed (left-to-right) in the order that they appear in the file (top to bottom).
- Max number of tiles shown per row (when the user expands the browser window size horizontally) should be driven by the maxHorizontalTiles key.
- Min number of tiles (when user shrinks the browser horizontally should be 1 (same as it is before this change)
The text was updated successfully, but these errors were encountered: