Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make main tiles configurable via deploy-templates #110

Merged
merged 6 commits into from
Apr 21, 2023
Merged

feat: make main tiles configurable via deploy-templates #110

merged 6 commits into from
Apr 21, 2023

Conversation

kaushik-rishi
Copy link
Contributor

@kaushik-rishi kaushik-rishi commented Apr 16, 2023 •
edited
Loading

Fixes issue #98

  • change the route to landing/node-deployment
  • use deploy-templates to get the data of the landing page
issue-98.mp4

My replit user profile

@kaushik-rishi kaushik-rishi marked this pull request as draft April 16, 2023 06:40
@kaushik-rishi kaushik-rishi mentioned this pull request Apr 16, 2023
Closed
4 tasks
@kaushik-rishi kaushik-rishi marked this pull request as ready for review April 16, 2023 16:06
@kaushik-rishi
Copy link
Contributor Author

@anilmurty can you please review and suggest improvements/changes ?

@anilmurty
Copy link
Contributor

Awesome @kaushik-rishi - @jtary should be able to review/ merge this tomorrow if it looks good.

@anilmurty
Copy link
Contributor

Please verify an end-to-end deployment with Console (including close deployment) to make sure nothing is broken.

@kaushik-rishi
Copy link
Contributor Author

Please verify an end-to-end deployment with Console (including close deployment) to make sure nothing is broken.

Will do early morning once i wake up.

@kaushik-rishi kaushik-rishi mentioned this pull request Apr 18, 2023
Open
3 tasks
@anilmurty anilmurty requested a review from jtary April 18, 2023 23:44
@anilmurty anilmurty mentioned this pull request Apr 20, 2023
Open
4 tasks
@anilmurty
Copy link
Contributor

hey there - just checking in if you have verified a deployment after this change and this is good to review and merge? Thanks

@kaushik-rishi
Copy link
Contributor Author

@anilmurty Need some help regarding verifying the deployment and testing.

@kaushik-rishi
Copy link
Contributor Author

@anilmurty Seems like you've trasnferred me some more AKT for testing purpose. I will check and let you know.

Is it enough if i just check deploying an Akash RPC node, or should i also test with a custom sdl ?

@anilmurty
Copy link
Contributor

even just a tetris deployment (faster than akash rpc node) should be sufficient.

@kaushik-rishi
Copy link
Contributor Author

@anilmurty

  • tested with a mysql custom sdl
  • tested with a akash rpc node deployment
  • re-check and ensure styling and code quality

Should be good to merge, your take now.

@anilmurty
Copy link
Contributor

Awesome. Thanks so much. @jtary - can you please review and merge if OK? (I will too)

@anilmurty anilmurty self-requested a review April 21, 2023 20:49
@jtary jtary merged commit 9b83081 into akash-network:main Apr 21, 2023
github-actions bot pushed a commit that referenced this pull request Apr 21, 2023
@web-flow
feat: make main tiles configurable via deploy-templates (#110)
1cb57af 
* wip: make main tiles configurable via deploy-templates
* fix: asset filenames
* feat: view all button for templates
* change: route from new-deployment to landing/node-deployment
* fix: keep the deployment creation pages still at /new-deployment route
* fix dev bug 0.1.272
@gosuri gosuri added the community-contribution Fix from awesome community members label Apr 24, 2023
@anilmurty anilmurty mentioned this pull request Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anilmurty anilmurty anilmurty approved these changes

@jtary jtary jtary approved these changes

Assignees
No one assigned
Labels
community-contribution Fix from awesome community members
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaushik-rishi @anilmurty @jtary @gosuri