-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new landing page with separate sections and guidelines #116
base: main
Are you sure you want to change the base?
feat: add new landing page with separate sections and guidelines #116
Conversation
@kaushik-rishi - please confirm that you tested at least a basic tetris deployment with these changes. @jtary - this PR addresses akash-network/console#100 |
Hey @kaushik-rishi, This PR has some conflicts with some other changes that were recently merged. Can you updated to resolve those conflicts? Also, please append the title of the PR with conventional commit keyword. Something like:
Thanks 👋 |
@anilmurty ignore the merge conflicts as of now.
This is just to let you track progress. |
Thanks for the update @kaushik-rishi - great progress! 🚀 |
@jtary - need help with the file https://github.com/akash-network/console/blob/68647d6769ee69b4f88464e8e90660262456435b/web/src/components/NewLanding/CategoryCardsContainer.tsx As, we needed the Any better way to do it ? (Sorry, i'm new to using Formik) |
@jtary - can you please review/ respond to @kaushik-rishi so he can move forward with this? |
Hey @kaushik-rishi Sorry for the delay. I'll look into this and see what solutions I can come up with. |
Hey @kaushik-rishi I'm working on a bit of refactor to move the deployment business logic out of the stepper so that you'll be able to re-use it as part of the new flow easier. Hopefully have something up tomorrow you can use. Cheers. |
Hey @jtary |
Hey @kaushik-rishi The changes I was working on a going to take a while longer to complete. I'm going to be OOO for next week, but I found a simpler solution that should work to unblock you. If you are inside the formik component, you can use the const form = useFormikContext();
const sdl = form.values?.sdl;
form.setFieldValue('sdl', sdlValue); Otherwise, if you aren't inside the formik component, there are a series of mutations that you can use for the doing the deployment steps. You should only need one for what you're doing, as the once you have the deployment created, you can navigate to the configure-deployment page to handle the rest. Should look something like this:
|
Thanks @jtary . Acknowledged. |
Hey @kaushik-rishi just checking in here. Hope your exams went well. Are you able to work on this, this week? |
Addresses akash-network/console#100