fix: ensure apps build consistently in docker and locally #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygrishajev
force-pushed
the
feature/workspaces
branch
from
3608f11
to
371acf2
Compare
baktun14
reviewed
Jun 7, 2024
withing the context of the monorepo refs #209
ygrishajev
force-pushed
the
feature/workspaces
branch
from
371acf2
to
78a647d
Compare
|
I'll rebase the other 2 PRs once we're done with this one. I can also go the opposite way and merge this one and rebase the rest against main |
baktun14
approved these changes
Jun 7, 2024
Redm4x
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that all the core dependencies like
reactandnextare aligned across all monorepo apps/packages. Additionally, it updates the Docker files accordingly. With this PR, all builds and types get consistency across environments and build the same way in both Docker and locally within the context of the monorepo.NOTE: This is 1 of 3 PR which should be merged together. It should be reviewed 1st and merged last after #232