Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial set of bumps #1719

Closed
wants to merge 3 commits into from
Closed

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Nov 22, 2022

Description

This PR attempts to fix the issue cluster that seems to stem from uneven iavl store heights and manifests as only being able to use pruning=nothing.

Likely first experienced by EVMOS.

Documented here, reports are useful:
cosmos/cosmos-sdk#13933

This PR also addresses a situation caused by mixed versions of the Go runtime, documented here:

cosmos/cosmos-sdk#13976

IBC-go v3.1.1 is deprecated:

https://github.com/cosmos/ibc-go/releases/tag/v3.1.1

Akash should do a state-breaking change either by halt height or by gov.

Caveats

The actual solution may be here:

cosmos/cosmos-sdk#13935

The actual-actual solution may be this:

cosmos/cosmos-sdk#12228

big picture

Merge:
tendermint/tendermint#9742

...to make tendermint just tendermint and reduce build complexity and save time

  • Put ibc-go back in cosmos-sdk
  • put iavl in the cosmos-sdk
  • put the ledger libraries in the cosmos-sdk

Motivation and Context

It tries to fix the cluster.

How Has This Been Tested?

It hasn't.

Types of changes

  • Bug fix (non-breaking change which fixes an issue) <- that's what I am shooting for
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change) <- that's what it is

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@faddat faddat requested review from boz and troian as code owners November 22, 2022 20:42
@troian
Copy link
Member

troian commented Nov 23, 2022

superseded by #1722

@troian troian closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants