Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Blade component to accept currency objects #106

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

hkan
Copy link

@hkan hkan commented Jun 29, 2024

This change enables app templates to be shorter.

$currency = \Akaunting\Money\Currency::GBP();

// Before this PR, this template would throw an error:
<x-money amount="1000" :currency="$currency" />

// One would have to do this:
<x-money amount="1000" :currency="$currency->getCurrency()" />

Now it works. It's no longer a requirement to pass the 3-character string of the currency.

@hkan
Copy link
Author

hkan commented Aug 17, 2024

Hi @denisdulici, have you or someone in the company had a chance to take a look? Can I somehow help get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant