This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Autoconnect fix transparent #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING: please hold on a bit on this... I just discovered the Connection callback work well with autoConnect, but not with Connect anymore. Will be uploading a fix soon. |
|
It should be fixed now. The problem was partially in my application, that was calling stopAutoConnect() just as a precaution when doing a normal connect(), and was removing the callback... but having the fix in the library is better. I have found plenty of these checks missing: the library does not prevent you from breaking it. We'll get there I guess :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is it for fixing #10 . I tried it and works fine.
I wonder why don't you try to reconnect on onDeviceDisconnected(). This essentially means that, if you disconnect(), you need to reconfigure autoConnect all over again.
Bonus points: it would be very interesting to set some sort of timeout on each reconnection: when something goes wrong it tries to reconnect very fast and gives a StackOverflow.