fix: Improve type prefix and suffix extraction

[iron3oxide]

Refactored the logic in get_prefix_and_suffix function to improve type prefix and suffix extraction. Now using rsplit method to accurately extract the prefix and suffix from the input string.

Closes #12

[akhundMurad]

Hello @iron3oxide
Your changes broke the TypeID spec validation.
Please try to resolve them and add additional tests to your case.
Thanks for your contribution!

[iron3oxide]

Done! My pleasure

[iron3oxide]

@khasizadaj I am replying here because it is easier to follow the conversation this way. I don't quite understand your suggested changes.

To preface this: In my opinion, get_prefix_and_suffix() should aim to do just that: extract the prefix and suffix candidates from the given string. A special case where it is preferable to raise an error early is a single leading underscore in the given string.

After that it is up to the TypeID class to correctly flag the given prefix and suffix as invalid; which it does, as the tested string in the test you mentioned contains a valid prefix according to the TypeID spec, but no valid suffix. A string such as "___test_invalid_00041061050r3gg28a1c60t3gf" is also correctly flagged as containing an invalid prefix. Could you give me an example string where the changes suggested in this PR produce an unexpected or wrong outcome?

[khasizadaj]

Thanks for the clarification. I was thinking that it could be useful to throw exception before that as well, but now I understand your POV as well. We can disregard my comment.

[akhundMurad]

@iron3oxide @khasizadaj
may I resolve the conversation above?

[iron3oxide]

Yes, I think it's ready to be merged

[akhundMurad]

@iron3oxide @khasizadaj
thanks, guys!
I will include it in the next release.

[khasizadaj]

Yes, it can be closed! Thanks a lot, @iron3oxide.