Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the implementation of
from_string
andfrom_uuid
to classmethods of the same name.That means instead of
...you can now write:
I've kept the old methods around for now, but they defer to the new classmethods as the source implementation. If you're onboard with this change you could also consider dropping them, but they probably don't hurt and it would be a breaking change.
Motivation
classmethod()
for a variant that is useful for creating alternate class constructors."1)typeid
package, because it's likely you'll already importTypeID
anyway for e.g. function param or return typing (def find_by_id(id: TypeID)
).from_string
is a fairly ambiguous name, and importing it in a large file might often need an aliasTypeID
) rather than the constructors for each library ("Was itfrom_uuid
orget_by_uuid
...?")TypeID.fromString
andTypeID.fromUUID
Footnotes
https://docs.python.org/3/library/functions.html#staticmethod ↩