Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Autoloader #73

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Implement Autoloader #73

merged 3 commits into from
Jan 24, 2024

Conversation

pfefferle
Copy link
Collaborator

Maybe we should also change the oauth classes to follow the same syntax (with class- prefix and folder with capital "O").

maybe we should change the oauth classes to follow the same syntax (with `class-` prefix and folder with capital "O").
@pfefferle pfefferle requested a review from akirk January 23, 2024 09:30
@akirk
Copy link
Owner

akirk commented Jan 24, 2024

Yes, let's do that!

@akirk
Copy link
Owner

akirk commented Jan 24, 2024

I have opted to keep the directory lowercase oauth2, one reason being that you cannot use git mv to rename it on macOS since its a case insensitive filesystem and thus you'd be renaming it to itself...?

@pfefferle
Copy link
Collaborator Author

Perfect!

@akirk akirk merged commit 9998ea1 into main Jan 24, 2024
38 checks passed
@akirk akirk deleted the add/autoloader branch January 24, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants