Fix reply with quoted comma #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
co- Properly split addresses into name and email - Deal with them as (name, email) tuples internally, as a (quoted) name can contain a comma - Format them properly again when inserting into the message Fixes akissinger#75
this handles quoted values correctly and we avoid reinventing the wheel.
The-Compiler
force-pushed
the
fix-reply-quoted-comma
branch
from
3a23cc9 to
780dfff
Compare
|
Rebased and force-pushed to fix trivial conflict after #71 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #75 and also did a couple of drive-by refactorings. Maybe best reviewed commit by commit, though the full diff isn't horribly big either.