feat: Better name for rich status metadata, better details lookup API #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
commented
Dec 21, 2022
| @@ -67,13 +65,13 @@ public void testNativeApi() throws Exception { | |||
| }).get(); | |||
|
|
|||
| GrpcServiceException ex = GrpcServiceException.apply(statusRuntimeException); | |||
| RichMetadata meta = (RichMetadata) ex.getMetadata(); | |||
| MetadataStatus meta = (MetadataStatus) ex.getMetadata(); | |||
There was a problem hiding this comment.
Went with status since that is the google rpc name of it
johanandren
commented
Dec 21, 2022
| def getCode(): Int | ||
| def getMessage(): String | ||
| def getDetails(): List[com.google.protobuf.any.Any] | ||
| def getParsedDetails[K <: scalapb.GeneratedMessage](index: Int, companion: scalapb.GeneratedMessageCompanion[K]): K | ||
| def getParsedDetails[K <: scalapb.GeneratedMessage](companion: scalapb.GeneratedMessageCompanion[K]): List[K] |
There was a problem hiding this comment.
Likely contain only one of each type, but it's also possible with many, LocalizedMessage would be one per language for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1665