fix: Don't log peer closing connection at error #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
approved these changes
Jan 24, 2023
| private def default(system: ActorSystem): jFunction[Throwable, Trailers] = | ||
| private def default(system: ActorSystem): jFunction[Throwable, Trailers] = { | ||
| val log = Logging(system, "akka.grpc.javadsl.GrpcExceptionHandler") | ||
|
|
There was a problem hiding this comment.
This isn't called repeatedly, which would add overhead of creating logger?
There was a problem hiding this comment.
In the Kalix proxy we create the partial function once at bootstrap (Serve.createRoute) and re-use for all calls, so a slight optimization for the peer closed and unexpected error scenarios. Not very important though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream fix for akka/akka-http#4041
As we don't have information about how to reproduce, matching the logged error message is the best I could do and I think this is where the exception is logged at error.