Improve validation in uuid unmarshaller #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka-ci
added
validating
|
Test PASSed. |
raboof
reviewed
Jul 4, 2019
...http/src/main/scala/akka/http/scaladsl/unmarshalling/PredefinedFromStringUnmarshallers.scala
Outdated
Show resolved
Hide resolved
Philippus
force-pushed
the
improve-uuid-unmarshaller
branch
from
ab49063 to
6d9eeee
Compare
akka-ci
added
validating
|
Test PASSed. |
raboof
reviewed
Jul 4, 2019
...http/src/main/scala/akka/http/scaladsl/unmarshalling/PredefinedFromStringUnmarshallers.scala
Outdated
Show resolved
Hide resolved
Philippus
force-pushed
the
improve-uuid-unmarshaller
branch
from
6d9eeee to
3c7b573
Compare
akka-ci
added
validating
|
Test PASSed. |
raboof
approved these changes
Jul 8, 2019
This was referenced Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve the validation in the uuid unmarshaller.
References
Follows #2505 which introduced the unmarshaller.
Changes
Uses a regex that accepts uuid's as defined in RFC 4122. A special case is added for the nil uuid. Also avoids a try/catch block.
Background Context
The validation in
UUID.fromString-method in java 8 is pretty poor and accepts a lot of invalid uuid strings, java 9 improves on it somewhat but is still far too accepting.