Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify migration and retrieval of durable state based persistence ids #544

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

sebastian-alfers
Copy link
Contributor

No description provided.

@sebastian-alfers sebastian-alfers marked this pull request as draft April 5, 2024 08:26
docs/src/main/paradox/migration.md Outdated Show resolved Hide resolved
@@ -74,6 +76,8 @@ The migration tool can be run as main class `akka.persistence.r2dbc.migration.Mi

Durable State is not migrated by `MigrationTool.migrateAll`, instead you need to use `MigrationTool.migrateDurableStates` for a given list of persistence ids.

This list can be retrieved by using `currentPersistenceIds` of @ref:[Durable state queries](./query.md#durable-state-queries).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is misleading because you would have to retrieve them from the source (old) database, and akka-persistence-jdbc doesn't implement that query. Isn't it obvious that you can retrieve such list of persistence ids with just sql select?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I have to remove that sentence as it was a misunderstanding.

@@ -9,6 +9,8 @@ idempotent result. Full rolling update when switching database or Persistence pl
you can migrate most of the data while the system is online and then have a short full shutdown while
migrating the remaining data that was written after the previous online migration.

The migration tool is intended to run as a separate, standalone application and should not be part of the same jvm process as the main application is running under.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastian-alfers Is this PR ready?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@patriknw patriknw marked this pull request as ready for review July 1, 2024 13:23
@patriknw
Copy link
Member

patriknw commented Jul 1, 2024

Flaky SQL Server test, but ignoring that since this is clearly just a doc addition

@patriknw patriknw merged commit 7bc097b into akka:main Jul 1, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants