chore: drop revision from Durable State by slice index and migration docs #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Apr 24, 2024
| : ```sql | ||
| DROP INDEX IF EXISTS durable_state_slice_idx; | ||
| CREATE INDEX IF NOT EXISTS durable_state_slice_idx ON durable_state(slice, entity_type, db_timestamp); | ||
| ``` |
There was a problem hiding this comment.
Maybe we should clarify that this migration is optional. If someone is already using it I don't think it would hurt much to just continue with the existing index. Maybe same with the primary key. As mentioned below, there can be a huge performance impact on the db to recreate the index if the data volume is large.
There was a problem hiding this comment.
If optional, and not even required for the migration anymore, can we just skip it from the docs? But of course, we can highlight this.
There was a problem hiding this comment.
Also, see that this section is currently under the following headline:
Durable State table schema change (optional)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned in #558 (comment)