Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor cleanup #581

Merged
merged 3 commits into from
Jun 13, 2024
Merged

chore: minor cleanup #581

merged 3 commits into from
Jun 13, 2024

Conversation

patriknw
Copy link
Member

No description provided.

@@ -88,7 +89,7 @@ class PayloadSpec
}

private def selectJournalRow(persistenceId: String): TestRow = {
import settings.codecSettings.JournalImplicits.journalPayloadCodec
implicit val codec: PayloadCodec = settings.codecSettings.JournalImplicits.journalPayloadCodec
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scala3 doesn't like the import from settings, which is now a lazy val in trait.

[error] -- Error: /Users/patrik/dev/akka-persistence-r2dbc/core/src/test/scala/akka/persistence/r2dbc/PayloadSpec.scala:90:34
[error] 90 |    import settings.codecSettings.JournalImplicits.journalPayloadCodec

Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octonato
Copy link
Member

Failing tests probably due some flakiness. Restart it.

@patriknw patriknw merged commit 408ac9a into main Jun 13, 2024
9 checks passed
@patriknw patriknw deleted the wip-chore-patriknw branch June 13, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants