Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Programatic connection factory options #587

Merged
merged 3 commits into from
Aug 6, 2024
Merged

feat: Programatic connection factory options #587

merged 3 commits into from
Aug 6, 2024

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Aug 5, 2024

  • Possibility to amend the ConnectionFactoryOptions

@patriknw
feat: Programatic connection factory options
7c7afca 
* Possibility to amend the ConnectionFactoryOptions
pvlugter
pvlugter reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Some tests failing with No configuration setting found for key 'options-provider'.

core/src/main/resources/reference.conf Outdated Show resolved Hide resolved
@patriknw @pvlugter
Review suggestion
04c35b1 
Co-authored-by: Peter Vlugter <59895+pvlugter@users.noreply.github.com>
@patriknw
R2dbcSettingsSpec
e51acb8 
* and move config to dialect section since it's not supported by H2
@patriknw patriknw merged commit cf04b9f into main Aug 6, 2024
9 checks passed
@patriknw patriknw deleted the wip-options-provider-patriknw branch August 6, 2024 08:13
@patriknw patriknw added this to the 1.2.5 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvlugter pvlugter pvlugter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@patriknw @pvlugter