feat: Recovery based on only the last event #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
commented
Jan 24, 2025
| @@ -137,23 +138,44 @@ private[r2dbc] class PostgresQueryDao(executorProvider: R2dbcExecutorProvider) e | |||
| protected def selectOneEventSql(slice: Int): String = | |||
| sqlCache.get(slice, "selectOneEventSql") { | |||
| sql""" | |||
| SELECT slice, entity_type, db_timestamp, $sqlDbTimestamp AS read_db_timestamp, event_ser_id, event_ser_manifest, event_payload, meta_ser_id, meta_ser_manifest, meta_payload, tags | |||
| SELECT entity_type, db_timestamp, $sqlDbTimestamp AS read_db_timestamp, event_ser_id, event_ser_manifest, event_payload, meta_ser_id, meta_ser_manifest, meta_payload, tags | |||
There was a problem hiding this comment.
removal of the slice column in some selects is an unrelated cleanup. retrieve of slice is unnecessary since we already have the slice.
| .map(_.map(row => deserializeSnapshotRow(row, serialization))) | ||
| def loadAsync(persistenceId: String, criteria: SnapshotSelectionCriteria): Future[Option[SelectedSnapshot]] = { | ||
| if (criteria.maxSequenceNr <= 0) | ||
| FutureNone |
There was a problem hiding this comment.
optimization, it would otherwise query the db also for disabled snapshot criteria
johanandren
approved these changes
Jan 28, 2025
patriknw
force-pushed
the
wip-recover-last-patriknw
branch
from
d1a01e2 to
fb42e10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of akka/akka#32629