bump: akka-persistence-r2dbc 1.2.5 in samples #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pin sql server and update yugabyte docker compose in #1179 |
|
we have some mix of Akka 2.9.3 and 2.9.4 in samples because of this, I'll take a look |
pvlugter
reviewed
Aug 14, 2024
Comment on lines
51
to
63
| final case class RuntimeState( | ||
| items: ORSet[Item], | ||
| closed: Set[ReplicaId], | ||
| checkedOut: Option[Instant], | ||
| vipCustomer: Boolean) | ||
| extends CborSerializable { | ||
|
|
||
| def foo(oldState: State, newState: State): RuntimeState ={ | ||
| val newItems = newState.items.diff(oldState.items) | ||
| items.+() | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Was the shopping cart sample code expected to be updated in this PR? Don't see RuntimeState used.
There was a problem hiding this comment.
Thanks, that must be some completely unrelated exeriment.
* and Akka 2.9.4 since that is the version from r2dbc
patriknw
force-pushed
the
wip-r2dbc-1.2.5-patriknw
branch
from
1e07ae9
to
bd85df8
Compare
pvlugter
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.