Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Distributed Cluster Example Project #1184

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

janikdotzel
Copy link
Contributor

I discovered that the sample project from the Akka DC docs was throwing an error, when I run the following command from the README:

grpcurl -d '{"cartId":"cart1"}' -plaintext 127.0.0.1:8101 shoppingcart.ShoppingCartService.MarkCustomerVip

The java implementation was missing an event handler for the CustomerMarkedVip event, so I added it.
The scala implementation is working correct.

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@johanandren johanandren merged commit 61b4810 into akka:main Aug 21, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants