-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jackson-databind 2.10.5.1 (was 2.10.5) #495
jackson-databind 2.10.5.1 (was 2.10.5) #495
Conversation
@@ -22,7 +22,7 @@ object Dependencies { | |||
val testContainers = "1.15.1" | |||
val junit = "4.13.1" | |||
val h2Driver = "1.4.200" | |||
val jackson = "2.10.5" // this should match the version of jackson used by akka-serialization-jackson | |||
val jackson = "2.10.5.1" // this should match the version of jackson used by akka-serialization-jackson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Akka 2.6.11 will use this version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can upgrade akka-projections to akka 2.6.11 and then upgrade jackson, but what if someone is using akka 2.6.10 or earlier? What are the odds that such a patch release will cause trouble?
Isn't that better for projections to stay on akka 2.6.10 and let it be transitively upgraded by the users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's used in kafka and examples. Wonder what we use it for in kafka?
Anyway, it should be ok to update to 2.10.5.1 here without updating Akka
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -22,7 +22,7 @@ object Dependencies { | |||
val testContainers = "1.15.1" | |||
val junit = "4.13.1" | |||
val h2Driver = "1.4.200" | |||
val jackson = "2.10.5" // this should match the version of jackson used by akka-serialization-jackson | |||
val jackson = "2.10.5.1" // this should match the version of jackson used by akka-serialization-jackson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's used in kafka and examples. Wonder what we use it for in kafka?
Anyway, it should be ok to update to 2.10.5.1 here without updating Akka
also build locally without issues, good for merge |
Updates com.fasterxml.jackson.core:jackson-databind from 2.10.5 to 2.10.5.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
Ignore future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:labels: library-update