Store offset for failed skipped envelope #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patriknw
commented
Feb 13, 2022
patriknw
commented
- need this to be able to fix one of the pending tests in akka-persistence-r2dbc
- makes more sense to try to store the offset when an envelope is skipped
patriknw
force-pushed
the
wip-skip-patriknw
branch
from
a916c33
to
0a256ae
Compare
* need this to be able to fix one of the pending tests in akka-persistence-r2dbc * makes more sense to try to store the offset when an envelope is skipped
patriknw
force-pushed
the
wip-skip-patriknw
branch
from
0a256ae
to
fc6d3fc
Compare
octonato
approved these changes
Feb 23, 2022
|
I think I review it when was draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.