feat: Improved custom tracing span API #10
Conversation
|
|
||
| // test expects a w3c encoded trace parent so here are some hoops to get that | ||
| // FIXME if this turns out to be a common need we could provide the w3c encoded traceparent from Tracing | ||
| // but for now leaving otel hoops to users is fine enough |
There was a problem hiding this comment.
Note that W3C (header) encoding of the trace context is just one way to encode it, might be the most common though, so users may want that for putting in events on message brokers etc.
The reason for us to provide convenience is mostly about the OTel API being messy and not allowing an easy way to just get the encoded string and use for whatever but some java injection design to allow many different headers etc (trace state as well as the traceparent).
There was a problem hiding this comment.
Yeah, I think this was the main reason we added it before. But we can always do it again in the future.
|
|
||
| // test expects a w3c encoded trace parent so here are some hoops to get that | ||
| // FIXME if this turns out to be a common need we could provide the w3c encoded traceparent from Tracing | ||
| // but for now leaving otel hoops to users is fine enough |
There was a problem hiding this comment.
Yeah, I think this was the main reason we added it before. But we can always do it again in the future.
|
CLA check is stuck. Closing and reopening. |
samples/tracing/src/main/java/com/example/tracing/api/TracingEndpoint.java
Outdated
Show resolved
Hide resolved
samples/tracing/src/main/java/com/example/tracing/application/TracingAction.java
Outdated
Show resolved
Hide resolved
akka-javasdk/src/main/java/akka/javasdk/http/RequestContext.java
Outdated
Show resolved
Hide resolved
|
I can't approve my own PR, but I approve this one. |
* feat: Improved custom tracing span API * Drop the tracing context, provide access to parent span if needed, update docs * Improved javadoc * review feedback --------- Co-authored-by: Johan Andrén <johan@markatta.com>
Bringing back Johan's PR (#3) that I broke.