-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main to java-spi #114
Changes from all commits
93e5e60
78cddd2
5b54ff9
8750d29
150bff3
dc8956c
74aa372
ed4bded
c8fc890
e5beb95
bff0a08
e30f49e
1c49a67
cd127b8
e6e7f73
898ec6f
05d658c
2ec5f11
488d784
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -167,7 +167,8 @@ class SdkRunner private (dependencyProvider: Option[DependencyProvider]) extends | |
startContext.remoteIdentification, | ||
startContext.tracerFactory, | ||
dependencyProvider, | ||
startedPromise) | ||
startedPromise, | ||
getSettings.devMode.map(_.serviceName)) | ||
Future.successful(app.spiComponents) | ||
} catch { | ||
case NonFatal(ex) => | ||
|
@@ -296,7 +297,8 @@ private final class Sdk( | |
remoteIdentification: Option[RemoteIdentification], | ||
tracerFactory: String => Tracer, | ||
dependencyProviderOverride: Option[DependencyProvider], | ||
startedPromise: Promise[StartupContext]) { | ||
startedPromise: Promise[StartupContext], | ||
serviceNameOverride: Option[String]) { | ||
private val logger = LoggerFactory.getLogger(getClass) | ||
private val serializer = new JsonSerializer | ||
private val ComponentLocator.LocatedClasses(componentClasses, maybeServiceClass) = | ||
|
@@ -617,7 +619,7 @@ private final class Sdk( | |
|
||
override val serviceInfo: SpiServiceInfo = | ||
new SpiServiceInfo( | ||
serviceName = sdkSettings.devModeSettings.map(_.serviceName).getOrElse(""), | ||
serviceName = serviceNameOverride.orElse(sdkSettings.devModeSettings.map(_.serviceName)).getOrElse(""), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ... and this changed in 898ec6f#diff-26d7c802dc1ff7174ab9cbed72a852b5d31ce32af07c96b7686aa89a67fc328cR447 @efgpinto pls confirm that this is correct There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yup, correct. looks good. 👍 |
||
sdkName = "java", | ||
sdkVersion = BuildInfo.version, | ||
protocolMajorVersion = BuildInfo.protocolMajorVersion, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
Install the Akka CLI: | ||
|
||
NOTE: In case there is any trouble with installing the CLI when following these instructions, please check xref:reference:cli/installation.adoc[]. | ||
|
||
[.tabset] | ||
Linux:: | ||
+ | ||
-- | ||
Download and install the latest version of `akka`: | ||
[source,bash] | ||
.... | ||
curl -sL https://doc.akka.io/install-cli.sh | bash | ||
.... | ||
|
||
-- | ||
macOS:: | ||
+ | ||
-- | ||
The recommended approach to install `akka` on macOS, is using https://brew.sh[brew, window="new"] | ||
|
||
[source,bash] | ||
---- | ||
brew install akka/brew/akka | ||
---- | ||
|
||
-- | ||
Windows:: | ||
+ | ||
-- | ||
|
||
. Download the latest version of `akka` from https://downloads.akka.io/latest/akka_windows_amd64.zip[https://downloads.akka.io/latest/akka_windows_amd64.zip] | ||
|
||
. Extract the zip file and move `akka.exe` to a location on your `%PATH%`. | ||
|
||
-- | ||
|
||
Verify that the Akka CLI has been installed successfully by running the following to list all available commands: | ||
|
||
[source, command window] | ||
---- | ||
akka help | ||
---- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ...