bug: Update curl to match code change #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efgpinto
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
LGTM
(separate question) I do wonder why do we have /hello/hello though... It seems intentional looking at the full page but at first sight it looked like a typo to me.. I guess the rational is we want to have /service/method but then I think using different terms could make it more obvious for the user.. Thoughts @beritou ?
ennru
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated response code change alters the endpoint to be hello-response - that is because the example code comes from the same code file that also has the hello endpoint unaltered. If we do not want to change the curl then we can update the code so it is separate files.