feat: gRPC endpoint support #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
force-pushed
the
wip-grpc-endpoints
branch
from
db89db6 to
4eb8068
Compare
johanandren
force-pushed
the
wip-grpc-endpoints
branch
from
4eb8068 to
39774e1
Compare
johanandren
force-pushed
the
wip-grpc-endpoints
branch
from
4965aef to
6ca32bc
Compare
efgpinto
approved these changes
Jan 23, 2025
| description.descriptor, | ||
| instanceFactory, | ||
| routeFactory) | ||
| } |
There was a problem hiding this comment.
I will certainly need to revisit this magic section later...
There was a problem hiding this comment.
Yeah the "integrate two generated code blocks with logic in the runtime" part is a bit tricky...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References https://github.com/lightbend/kalix-runtime/issues/3346